From 5d5421b7a2eb25735c00424ab5a2a831bb7777a2 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Mon, 1 Aug 2016 19:57:02 -0600 Subject: [PATCH] UPSTREAM: toolchain.inc: Update 'required toolchain' error text The old text said: *** building without the required toolchain. Stop. Where could be any of the coreboot stages - bootblock, verstage, ramstage, romstage. This error message was very misleading though, because what it actually meant was that it didn't know what architecture was required to build the stage, not that the toolchain was missing. Update the text to better reflect the actual issue, and to give the user a hint as to what to look for: *** The toolchain architecture for is unknown. *** Check your .config file for CONFIG_ARCH__* settings. Stop. BUG=None BRANCH=None TEST=None Change-Id: I5c52a3b49c06e4d0bc1cc1d7121d6ae7a6925979 Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/16024 Tested-by: build bot (Jenkins) Reviewed-by: Omar Pakker Reviewed-on: https://chromium-review.googlesource.com/368400 Commit-Ready: Furquan Shaikh Tested-by: Furquan Shaikh Reviewed-by: Aaron Durbin --- toolchain.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/toolchain.inc b/toolchain.inc index c8911939e8..21b07b4cba 100644 --- a/toolchain.inc +++ b/toolchain.inc @@ -111,7 +111,8 @@ set_stage_toolchain= \ # @2: compiler set to be used # e.g.: smm special class uses i386 as compiler set define create_class_compiler -$(if $(2),,$(error building $(1) without the required toolchain)) +$(if $(2),,$(warning *** The toolchain architecture for $(1) is unknown.) \ + $(error Check your .config file for CONFIG_ARCH_$(1)_* settings)) CC_$(1) := $(CC_$(2)) LD_$(1) := $(LD_$(2)) NM_$(1) := $(NM_$(2))