Emulation/switch-coreboot
1
0
Fork 0
mirror of https://github.com/fail0verflow/switch-coreboot.git synced 2025-05-04 01:39:18 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

UPSTREAM: drivers/elog: remove unnecessary check in elog_shrink()

Browse source 
There was a check against the next event offset against
the shrink size in elog_shrink(). However, all calls
to elog_shrink() were conditionalized on the next
event offset exceeding the full threshold. The shrink
size is set to the minimum of the full threshold and
a percentage of the elog region size. Therefore, it's
impossible for the next event offset to be less than
the shrink size because full threshold is always greater
than or equal to the shrink size.

BUG=chrome-os-partner:55932
BRANCH=None
TEST=None

Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/16093
Reviewed-by: Furquan Shaikh <furquan@google.com>

Change-Id: Ie6ff106f1c53c15aa36a82223a235a7ac97fd8c7
Reviewed-on: https://chromium-review.googlesource.com/368284
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Aaron Durbin 2016-08-03 23:01:50 -05:00 • committed by chrome-bot
parent 145d857af1
commit 5981272dcb
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/drivers/elog/elog.c
View file

@ -352,9 +352,6 @@ static int elog_shrink(void)
elog_debug("elog_shrink()\n");
if (next_event_offset < shrink_size)
return 0;
while (1) {
/* Next event has exceeded constraints */
if (offset > shrink_size)