From 593f577ffab9663fdf95fc7cc0b5f5bc623b52ae Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Fri, 7 Dec 2012 15:50:40 +0100 Subject: [PATCH] libpayload: Fix use of virtual pointers in sysinfo In I4c456f5, I falsely identified struct cb_string.string as a pointer which it is not. So we don't need phys_to_virt() here. Change-Id: I3e2b6226ae2b0672dfc6e0fa4f6990e14e1b7089 Signed-off-by: Nico Huber Reviewed-on: http://review.coreboot.org/1987 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer --- payloads/libpayload/arch/i386/coreboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/payloads/libpayload/arch/i386/coreboot.c b/payloads/libpayload/arch/i386/coreboot.c index fc22d9a05a..d39af4ab5d 100644 --- a/payloads/libpayload/arch/i386/coreboot.c +++ b/payloads/libpayload/arch/i386/coreboot.c @@ -150,7 +150,7 @@ static void cb_parse_framebuffer(void *ptr, struct sysinfo_t *info) static void cb_parse_string(unsigned char *ptr, char **info) { - *info = (char *)phys_to_virt(((struct cb_string *)ptr)->string); + *info = (char *)((struct cb_string *)ptr)->string; } static int cb_parse_header(void *addr, int len, struct sysinfo_t *info)