From 48eb6025f6fdb8f6fc64126568d0f4091e17013d Mon Sep 17 00:00:00 2001 From: Timothy Pearson Date: Mon, 9 Jan 2017 14:10:25 -0600 Subject: [PATCH] UPSTREAM: amd/mct/ddr3: Allow critical delay delta to go negative The critical delay delta was incorrectly specified as an unsigned short. Use a signed short instead. BUG=none BRANCH=none TEST=none Change-Id: Id41a1e68498d987db502f082a9402e34f5aa0c0a Signed-off-by: Patrick Georgi Original-Commit-Id: 5153cbfeb3498b75efdde6c7aa312d5920541702 Original-Found-by: Coverity Scan #1347355 Original-Change-Id: I37d769afb8c8af85a0375ae459e9d4ab0adcca74 Original-Signed-off-by: Timothy Pearson Original-Reviewed-on: https://review.coreboot.org/18071 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Martin Roth Original-Reviewed-by: Paul Menzel Original-Tested-by: Raptor Engineering Automated Test Stand Reviewed-on: https://chromium-review.googlesource.com/428241 Commit-Ready: Aaron Durbin --- src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c index 0892857e68..7b9fa6555a 100644 --- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c +++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c @@ -3028,7 +3028,7 @@ void fam15EnableTrainingMode(struct MCTStatStruc *pMCTstat, uint8_t lane; uint8_t dimm; uint16_t max_cdd_we_delta; - uint16_t cdd_trwtto_we_delta; + int16_t cdd_trwtto_we_delta; uint8_t receiver; uint8_t lane_count; uint8_t x4_present = 0;