From 33b86a139c88b2045e2e61f1dfbbac9fcfeaeb60 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Thu, 15 Dec 2016 14:59:37 +0100 Subject: [PATCH] UPSTREAM: util/broadcom: Initialize variable It's later tested for NULL, but never initialized to make that test work reliably. Change-Id: Iadee1af224507a6dd39956306f3eafa687895176 Original-Signed-off-by: Patrick Georgi Original-Found-by: Coverity Scan #1323515 Original-Reviewed-on: https://review.coreboot.org/17880 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Martin Roth Signed-off-by: Aaron Durbin Reviewed-on: https://chromium-review.googlesource.com/421214 Reviewed-by: Patrick Georgi --- util/broadcom/secimage/sbi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/broadcom/secimage/sbi.c b/util/broadcom/secimage/sbi.c index 58d4a39989..8718f14d34 100644 --- a/util/broadcom/secimage/sbi.c +++ b/util/broadcom/secimage/sbi.c @@ -77,12 +77,12 @@ int AddImagePayload(char *h, char *filename, unsigned int filesize) *---------------------------------------------------------------------*/ int CreateSecureBootImage(int ac, char **av) { - char *outfile, *configfile, *arg, *privkey = NULL, *bl = NULL; + char *configfile = NULL, *arg, *privkey = NULL, *bl = NULL; int status = 0; uint32_t sbiLen; struct stat file_stat; uint32_t add_header = 1; - outfile = *av; + char *outfile = *av; unsigned int filesize; char *buf; --ac; ++av;