From 30d88884c545cecd7f22f80255f1cf0c46ef5a41 Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Fri, 18 Nov 2016 11:35:01 -0700 Subject: [PATCH] UPSTREAM: console/vtxprintf.c: cast precision to size_t for string length If no maximum string length is specified, we're intentionally passing a value of -1 to get the string length so that it's not limited. This makes checking tools unhappy, so actively cast it to size_t before passing it into strlen to show that it's not an accident. Addresses coverity issue 1129133 - Argument cannot be negative BUG=None BRANCH=None TEST=None Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/17479 Tested-by: build bot (Jenkins) Reviewed-by: Nico Huber Change-Id: I40f8f2101e170a5c96fcd39c217aa414f4316473 Reviewed-on: https://chromium-review.googlesource.com/415044 Commit-Ready: Aaron Durbin Tested-by: Furquan Shaikh Reviewed-by: Aaron Durbin --- src/console/vtxprintf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/console/vtxprintf.c b/src/console/vtxprintf.c index d20a387d44..5f37253e7d 100644 --- a/src/console/vtxprintf.c +++ b/src/console/vtxprintf.c @@ -228,7 +228,7 @@ repeat: if (!s) s = ""; - len = strnlen(s, precision); + len = strnlen(s, (size_t)precision); if (!(flags & LEFT)) while (len < field_width--)