mirror of
https://github.com/fail0verflow/switch-coreboot.git
synced 2025-05-04 01:39:18 -04:00
UPSTREAM: riscv: Suppress invalid coverity errors
Coverity is detecting 'sp' as a variable which has not been initialized.
This is obviously not correct, so this patch *TRIES* to mark it as false
I'm not positive that this will work because the annotation needs to go
on the line above the error, but this error is inside of a # define.
Does the whole #define count as one line? Can it go on the line
above the #define in the .h file? Does it have to precede every line
where the #define is used? The documentation doesn't make this clear.
Should suppress coverity issues: 1368525 & 1368527
uninit_use: Using uninitialized value sp.
BUG=none
BRANCH=none
TEST=none
Change-Id: I8fa056af3e829218d8139f3899b7291e62ea6796
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: f797a1ac6a
Original-Change-Id: Ibae5e206c4ff47991ea8a11b6b59972b24b71796
Original-Signed-off-by: Martin Roth <martinroth@google.com>
Original-Reviewed-on: https://review.coreboot.org/18247
Original-Tested-by: build bot (Jenkins)
Original-Reviewed-by: Jonathan Neuschfer <j.neuschaefer@gmx.net>
Reviewed-on: https://chromium-review.googlesource.com/445149
This commit is contained in:
parent
ed5d162c37
commit
243af848bc
1 changed files with 1 additions and 0 deletions
|
@ -70,6 +70,7 @@ typedef struct {
|
|||
} hls_t;
|
||||
|
||||
#define MACHINE_STACK_TOP() ({ \
|
||||
/* coverity[uninit_use] : FALSE */ \
|
||||
register uintptr_t sp asm ("sp"); \
|
||||
(void*)((sp + RISCV_PGSIZE) & -RISCV_PGSIZE); })
|
||||
|
||||
|
|
Loading…
Add table
Reference in a new issue