From 217915f94fe6ea68fca93d915eb8718b1300dba8 Mon Sep 17 00:00:00 2001 From: Duncan Laurie Date: Mon, 10 Apr 2017 21:07:06 -0700 Subject: [PATCH] UPSTREAM: google/eve: Disable Deep S3 in AC mode In order to support a standard "docked" config disable Deep S3 when connected to AC power. This allows USB devices to wake the device from suspend if it is externally powered, but still retains the lower power state when running on battery. BUG=b:36723679 BRANCH=none TEST=manual testing on Eve for USB wake behavior: 1) when suspended on battery USB keyboard does not wake 2) when suspended while connected to AC a USB keyboard does wake 3) if suspended with AC, and then AC is removed, system does not wake with USB keyboard 4) if suspended without AC, and then AC is added, system does not wake with USB keyboard (it cannot get enabled without waking and re-suspending) Change-Id: I522b50c16fa0c4c3ba3731075fe29d3e799935d4 Signed-off-by: Patrick Georgi Original-Commit-Id: 73ff0fbd2e54c742ad9d2d052cb5601eb369c61d Original-Change-Id: I670e39d42cdb5b80612206da899be82ef3b2cbf2 Original-Signed-off-by: Duncan Laurie Original-Reviewed-on: https://review.coreboot.org/19240 Original-Tested-by: build bot (Jenkins) Original-Reviewed-by: Furquan Shaikh Original-Reviewed-by: Aaron Durbin Reviewed-on: https://chromium-review.googlesource.com/480098 --- src/mainboard/google/eve/devicetree.cb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb index f995ab7d37..7db97b7354 100644 --- a/src/mainboard/google/eve/devicetree.cb +++ b/src/mainboard/google/eve/devicetree.cb @@ -1,7 +1,7 @@ chip soc/intel/skylake # Enable deep Sx states - register "deep_s3_enable_ac" = "1" + register "deep_s3_enable_ac" = "0" register "deep_s3_enable_dc" = "1" register "deep_s5_enable_ac" = "1" register "deep_s5_enable_dc" = "1"