UPSTREAM: sb/intel/ibexpeak: Update debug code to match other chips

Other chips dump tco_status here if it wasn't handled, which makes
sense.

tco_sts can't be zero here, because the call would have already returned
if it were.  Also, dump_tco_status wouldn't print anything if tco_sts
were zero.

This will still only print the debug information if DEBUG_SMI is
enabled in Kconfig, so in general, this change won't have much of an
effect on anything.

BUG=none
BRANCH=none
TEST=none

Change-Id: Icfe18802dfe054409e3e0ca111a3a0c272ab2a2d
Signed-off-by: Patrick Georgi <pgeorgi@chromium.org>
Original-Commit-Id: 3e3b858888
Original-Found-by: Coverity Scan #1229598
Original-Change-Id: Id2c69a16817ba18dfa051f514138fbc04a2f7bee
Original-Signed-off-by: Martin Roth <martinroth@google.com>
Original-Reviewed-on: https://review.coreboot.org/18101
Original-Tested-by: build bot (Jenkins)
Original-Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Original-Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://chromium-review.googlesource.com/428256
Commit-Ready: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Martin Roth 2017-01-11 10:10:17 -07:00 committed by chrome-bot
parent 15095efc4b
commit 17b61437bb

View file

@ -709,7 +709,7 @@ static void southbridge_smi_tco(void)
} else if (tco_sts & (1 << 3)) { /* TIMEOUT */
/* Handle TCO timeout */
printk(BIOS_DEBUG, "TCO Timeout.\n");
} else if (!tco_sts) {
} else {
dump_tco_status(tco_sts);
}
}