Emulation/switch-coreboot
1
0
Fork 0
mirror of https://github.com/fail0verflow/switch-coreboot.git synced 2025-05-04 01:39:18 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improve printk documentation to match code realities.

Browse source 
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Corey Osgood <corey.osgood@gmail.com>


git-svn-id: svn://coreboot.org/repository/LinuxBIOSv3@510 f3766cd6-281f-0410-b1cd-43a5c92072e9
This commit is contained in:
Carl-Daniel Hailfinger 2007-11-16 11:17:57 +00:00
parent f05e9a7d8a
commit 09f99f998d
4 changed files with 17 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
arch/x86/stage1.c
View file

@ -102,13 +102,16 @@ void __attribute__((stdcall)) stage1_main(u32 bist)
}
// We have cache as ram running and can start executing code in C.
//
hardware_stage1();
//
uart_init(); // initialize serial port
console_init(); // print banner
/* Exactly from now on we can use printk to the serial port.
* Celebrate this by printing a LB banner.
*/
console_init();
if (bist!=0) {
printk(BIOS_INFO, "BIST FAILED: %08x", bist);

11
lib/stage2.c
View file

@ -37,7 +37,8 @@
*
* Device Enumeration: in the dev_enumerate() phase.
*
* TODO: Check whether this documentation is still correct. Improve it.
* TODO:
* - Check whether this documentation is still correct. Improve it.
*/
int stage2(void)
{
@ -54,7 +55,13 @@ int stage2(void)
post_code(0x20);
/* TODO: Explain why we use printk here although it is impossible */
/* TODO: Explain why we use printk here although it is claimed to be
* impossible according to the documentation. The "has to be done
* before printk can be used" comment below seems to suggest the same.
* However, we already enable serial in arch/x86/stage1.c:stage1_main()
* when we call hardware_stage1(); uart_init(); console_init();
* Why test the console again if it already is tested in stage 1?
*/
printk(BIOS_NOTICE, console_test);
dev_init();

3
mainboard/adl/msm800sev/stage1.c
View file

@ -36,6 +36,8 @@
#define SERIAL_DEV W83627HF_SP1
#define SERIAL_IOBASE 0x3f8
/* printk will not yet output anything */
void hardware_stage1(void)
{
void w83627hf_enable_serial(u8 dev, u8 serial, u16 iobase);
@ -51,5 +53,4 @@ void hardware_stage1(void)
*/
cs5536_disable_internal_uart();
w83627hf_enable_serial(0x2e, SERIAL_DEV, SERIAL_IOBASE);
printk(BIOS_DEBUG, "Done %s\n", __FUNCTION__);
}

2
mainboard/emulation/qemu-x86/stage1.c
View file

@ -17,7 +17,7 @@
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
*/
/* no printk allowed until hardware is ready; hardware is ready */
/* printk will not yet output anything */
/**
* start up hardware needed for stage1